Skip to content

fix(button-toggle): not usable in high contrast mode #11097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 1, 2018

Fixes the following issues which made the button toggle hard to use for high contrast users:

  • The focus overlay being a solid color, causing it to hide the contents of its button.
  • Toggles and groups not having a border, making them blend in with the background.
  • Not being able to see which toggle is selected.

Fixes the following issues which made the button toggle hard to use for high contrast users:
* The focus overlay being a solid color, causing it to hide the contents of its button.
* Toggles and groups not having a border, making them blend in with the background.
* Not being able to see which toggle is selected.
@crisbeto crisbeto requested a review from tinayuangao as a code owner May 1, 2018 21:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 1, 2018
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels May 1, 2018
@josephperrott josephperrott merged commit dd2f465 into angular:master May 2, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants