Skip to content

fix(select): unable to toggle multi select option after using the mouse #11061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

Handles the following use case:

  1. Clicking on a multi-select to open it.
  2. Toggling an option with the mouse.
  3. Going to another option using the keyboard.
  4. Trying to toggle that option with the keyboard.

The issue comes from the fact that usually we manage keyboard events by keeping focus on the select trigger and managing the selection using aria-activedescendant. In this case, when the user clicks on a option, focus is moved to it which causes the select's keyboard handling to clash with the one that comes from mat-option, causing it to select and then deselect the option quickly. These changes restore focus back to the select trigger when an option is toggled.

Handles the following use case:
1. Clicking on a multi-select to open it.
2. Toggling an option with the mouse.
3. Going to another option using the keyboard.
4. Trying to toggle that option with the keyboard.

The issue comes from the fact that usually we manage keyboard events by keeping focus on the select trigger and managing the selection using `aria-activedescendant`. In this case, when the user clicks on a option, focus is moved to it which causes the select's keyboard handling to clash with the one that comes from `mat-option`, causing it to select and then deselect the option quickly. These changes restore focus back to the select trigger when an option is toggled.
@crisbeto crisbeto requested a review from kara as a code owner April 28, 2018 14:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 28, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 30, 2018
@josephperrott josephperrott removed the request for review from kara May 1, 2018 14:33
@josephperrott josephperrott merged commit 01d0993 into angular:master May 1, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants