fix(select): unable to toggle multi select option after using the mouse #11061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles the following use case: 1. Clicking on a multi-select to open it. 2. Toggling an option with the mouse. 3. Going to another option using the keyboard. 4. Trying to toggle that option with the keyboard. The issue comes from the fact that usually we manage keyboard events by keeping focus on the select trigger and managing the selection using `aria-activedescendant`. In this case, when the user clicks on a option, focus is moved to it which causes the select's keyboard handling to clash with the one that comes from `mat-option`, causing it to select and then deselect the option quickly. These changes restore focus back to the select trigger when an option is toggled.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
Accessibility
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the following use case:
The issue comes from the fact that usually we manage keyboard events by keeping focus on the select trigger and managing the selection using
aria-activedescendant. In this case, when the user clicks on a option, focus is moved to it which causes the select's keyboard handling to clash with the one that comes frommat-option, causing it to select and then deselect the option quickly. These changes restore focus back to the select trigger when an option is toggled.