Skip to content

fix(schematics): allow more tsconfig locations for ng update #11058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2018
Merged

fix(schematics): allow more tsconfig locations for ng update #11058

merged 3 commits into from
Apr 30, 2018

Conversation

jelbourn
Copy link
Member

Also delete the temp files if they're leftover from a previous failed run.

cc @StephenFluin @hansl

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: needs review target: patch This PR is targeted for the next patch release labels Apr 28, 2018
@jelbourn jelbourn added this to the 6.0 milestone Apr 28, 2018
@jelbourn jelbourn requested a review from mmalerba April 28, 2018 00:57
@jelbourn jelbourn requested a review from amcdnl as a code owner April 28, 2018 00:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 28, 2018
@jelbourn jelbourn force-pushed the ng-update-tsconfig-path branch from d3f778e to 72914da Compare April 28, 2018 00:58
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 30, 2018
@ngbot
Copy link

ngbot bot commented Apr 30, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@andrewseguin
Copy link
Contributor

LGTM - were you able to test this with an existing project?

@andrewseguin andrewseguin merged commit 7bbc040 into angular:master Apr 30, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @andrewseguin @googlebot