fix(table): Allow any Iterable or ArrayLike to be used for columns
#10822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
force-pushed
the
table-iterator
branch
2 times, most recently
from
8c70e1f to
b6e6509
Compare
crisbeto
reviewed
Apr 12, 2018
src/cdk/table/table.ts
Outdated
| @@ -535,7 +535,7 @@ export class CdkTable<T> implements CollectionViewer, OnInit, AfterContentChecke | |||
| */ | |||
| private _getHeaderCellTemplatesForRow(headerDef: CdkHeaderRowDef): CdkHeaderCellDef[] { | |||
| if (!headerDef || !headerDef.columns) { return []; } | |||
| return headerDef.columns.map(columnId => { | |||
| return Array.from(headerDef.columns).map(columnId => { | |||
There was a problem hiding this comment.
Fun fact: the second parameter of Array.from is a map function so you don't have to do .map afterwards.
There was a problem hiding this comment.
Today I learned. Updated.
josephperrott
force-pushed
the
table-iterator
branch
from
b6e6509 to
6d9f77d
Compare
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.