Skip to content

fix(scrolling): complete ScrollDispatcher.scrolled on destroy #10794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

Currently we stop emitting to scrolled once the provider is destroyed, however this can still leave some subscriptions hanging. These changes will also complete the scrolled subject.

Currently we stop emitting to `scrolled` once the provider is destroyed, however this can still leave some subscriptions hanging. These changes will also complete the `scrolled` subject.
@crisbeto crisbeto requested a review from andrewseguin as a code owner April 10, 2018 21:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 10, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 10, 2018
@mmalerba mmalerba merged commit 41be069 into angular:master Apr 16, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants