fix(datepicker): incorrect icon color #10458
Conversation
googlebot
added
the
cla: yes
| .mat-calendar-next-button, | ||
| .mat-calendar-previous-button { | ||
| .mat-datepicker-toggle, | ||
| .mat-calendar-next-button::after, |
There was a problem hiding this comment.
Do you have to target ::after explicitly? I would assume it would just inherit if you targeted the parent
There was a problem hiding this comment.
It was being overwritten by the .mat-icon-button if I target the parent. I think it depends on the order in which the style tags were added.
There was a problem hiding this comment.
I would just bump the specificity on the rule then, rather than just targeting the pseudo-element. The button may use the color to determine the color for ripples and things
There was a problem hiding this comment.
I wanted to avoid increasing the specificity, but I see your point that there could be other things depending on it. It's changed now.
* Fixes the datepicker previous and next icons having the wrong color, because they were being overwritten by the `.mat-icon-button` which sets it explicitly to `currentColor`. * Sets the inactive datepicker toggle to use the `icon` color.
crisbeto
force-pushed
the
datepicker-inaccurate-icon-color
branch
from
eb7edc6 to
0eaf817
Compare
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
.mat-icon-buttonwhich sets it explicitly tocurrentColor.iconcolor.