-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(datepicker): incorrect icon color #10458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): incorrect icon color #10458
Conversation
.mat-calendar-next-button, | ||
.mat-calendar-previous-button { | ||
.mat-datepicker-toggle, | ||
.mat-calendar-next-button::after, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have to target ::after
explicitly? I would assume it would just inherit if you targeted the parent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was being overwritten by the .mat-icon-button
if I target the parent. I think it depends on the order in which the style tags were added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just bump the specificity on the rule then, rather than just targeting the pseudo-element. The button may use the color to determine the color for ripples and things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to avoid increasing the specificity, but I see your point that there could be other things depending on it. It's changed now.
* Fixes the datepicker previous and next icons having the wrong color, because they were being overwritten by the `.mat-icon-button` which sets it explicitly to `currentColor`. * Sets the inactive datepicker toggle to use the `icon` color.
eb7edc6
to
0eaf817
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
.mat-icon-button
which sets it explicitly tocurrentColor
.icon
color.