fix(datepicker): overly broad selector in theme #10372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
googlebot
added
cla: no
Currently we've got the `:not(.mat-calendar-body-disabled):hover` selector in the datepicker theme which will match (almost) every single element on the page. This is unnecessary and can end up hurting performance down the road. These changes scope the selector only to datepicker cells.
crisbeto
force-pushed
the
datepicker-broad-selector
branch
from
bddaa58 to
762b75d
Compare
crisbeto
added
cla: yes
|
|
googlebot
removed
the
cla: yes
josephperrott
added
the
cla: yes
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we've got the
:not(.mat-calendar-body-disabled):hoverselector in the datepicker theme which will match (almost) every single element on the page. This is unnecessary and can end up hurting performance down the road. These changes scope the selector only to datepicker cells.