Skip to content

fix(slider): unable to slide to max value under certain conditions #10364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/lib/slider/slider.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,18 @@ describe('MatSlider without forms', () => {
it('should have aria-orientation horizontal', () => {
expect(sliderNativeElement.getAttribute('aria-orientation')).toEqual('horizontal');
});

it('should slide to the max value when the steps do not divide evenly into it', () => {
sliderInstance.min = 5;
sliderInstance.max = 100;
sliderInstance.step = 15;

dispatchSlideEventSequence(sliderNativeElement, 0, 1, gestureConfig);
fixture.detectChanges();

expect(sliderInstance.value).toBe(100);
});

});

describe('disabled slider', () => {
Expand Down
25 changes: 19 additions & 6 deletions src/lib/slider/slider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -635,16 +635,29 @@ export class MatSlider extends _MatSliderMixinBase

// The exact value is calculated from the event and used to find the closest snap value.
let percent = this._clamp((posComponent - offset) / size);

if (this._invertMouseCoords) {
percent = 1 - percent;
}
let exactValue = this._calculateValue(percent);

// This calculation finds the closest step by finding the closest whole number divisible by the
// step relative to the min.
let closestValue = Math.round((exactValue - this.min) / this.step) * this.step + this.min;
// The value needs to snap to the min and max.
this.value = this._clamp(closestValue, this.min, this.max);
// Since the steps may not divide cleanly into the max value, if the user
// slid to 0 or 100 percent, we jump to the min/max value. This approach
// is slightly more intuitive than using `Math.ceil` below, because it
// follows the user's pointer closer.
if (percent === 0) {
this.value = this.min;
} else if (percent === 1) {
this.value = this.max;
} else {
let exactValue = this._calculateValue(percent);

// This calculation finds the closest step by finding the closest
// whole number divisible by the step relative to the min.
let closestValue = Math.round((exactValue - this.min) / this.step) * this.step + this.min;

// The value needs to snap to the min and max.
this.value = this._clamp(closestValue, this.min, this.max);
}
}

/** Emits a change event if the current value is different from the last emitted value. */
Expand Down