Turn on strictNullChecks

[mikehaas763]

Is there any appetite for turning on typescript strictNullChecks mode? This is a recommended setting for new code bases. It's something I've already done for a decent portion of the material code base internally at my org so I have some experience with it.

If so, I'd be interested in submitting some PRs to work at getting us to that point.

[crisbeto]

I've been working on this already (I have most of the components sorted out). An issue with this is that @angular/forms doesn't seem to be compliant with it yet which ends up throwing a bunch of errors locally.

[mikehaas763]

@crisbeto ok cool. Which version of angular are you targeting when using strict checks?

[mikehaas763]

Along the same lines, I think we should also enable noImplicitAny. Is there any appetite for that as well? Should I create a separate issue to track that?

[crisbeto]

I was trying against one of the 4.0 RCs, I believe that is the first release that supports the null checks. As for noImplicitAny, it is already turned on.

[mikehaas763]

yeah you're right re 4.0 RC just wanted to make sure. Sorry about noImplicitAny reference for some reason I thought I turned it on myself locally.

[mikehaas763]

@crisbeto do you have your WIP pushed anywhere public?

[crisbeto]

I don't, I'll push the whole thing when it's done, but not rocket science, it's just making stuff nullable.

[mikehaas763]

I know just curious about the issues with forms, but ok then if you don't wanna push it idc.

[crisbeto]

I should have it over the next day or two, but here's the log from the forms module:

error TS2366: Function lacks ending return statement and return type does not include 'undefined'.
node_modules/@angular/forms/typings/src/model.d.ts(378,27): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; emitModelToViewChange?: boolea...' has no property 'onlySelf' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(378,37): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; emitModelToViewChange?: boolea...' has no property 'emitEvent' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(378,48): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; emitModelToViewChange?: boolea...' has no property 'emitModelToViewChange' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(378,71): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; emitModelToViewChange?: boolea...' has no property 'emitViewToModelChange' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(425,29): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'onlySelf' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(425,39): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'emitEvent' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(548,9): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'onlySelf' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(548,19): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'emitEvent' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(575,9): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'onlySelf' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(575,19): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'emitEvent' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(611,25): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'onlySelf' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(611,35): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'emitEvent' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(715,29): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'onlySelf' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(715,39): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'emitEvent' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(739,31): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'onlySelf' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(739,41): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'emitEvent' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(774,25): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'onlySelf' and no string index signature.
node_modules/@angular/forms/typings/src/model.d.ts(774,35): error TS2459: Type '{ onlySelf?: boolean | undefined; emitEvent?: boolean | undefined; } | undefined' has no property 'emitEvent' and no string index signature.