Skip to content

fix: exception while running command ng deploy (#2088) #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: exception while running command ng deploy (#2088) #2221

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d352cec
fix: exception while running command ng deploy (#2088)
ngdevelop-tech Oct 13, 2019
2438c34
Merge branch 'master' into ng-deploy-fix
ngdevelop-tech Oct 13, 2019
f706c32
Merge branch 'master' into ng-deploy-fix
NothingEverHappens Oct 24, 2019
00cb572
Merge branch 'master' into ng-deploy-fix
NothingEverHappens Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/schematics/deploy/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,14 @@ export default createBuilder<any>(
const project = workspace.getProject(context.target.project);

const firebaseProject = getFirebaseProjectName(
workspace.root,
context.target.project
);

try {
await deploy(
require("firebase-tools"),
context,
join(workspace.root, project.root),
project.root,
firebaseProject
);
} catch (e) {
Expand Down
4 changes: 1 addition & 3 deletions src/schematics/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { readFileSync } from "fs";
import { FirebaseRc, Project } from "./interfaces";
import { join } from "path";

export function listProjects() {
const firebase = require('firebase-tools');
Expand Down Expand Up @@ -57,11 +56,10 @@ export const projectPrompt = (projects: Project[]) => {
};

export function getFirebaseProjectName(
projectRoot: string,
target: string
): string | undefined {
const { targets }: FirebaseRc = JSON.parse(
readFileSync(join(projectRoot, ".firebaserc"), "UTF-8")
readFileSync(".firebaserc", "UTF-8")
);
const projects = Object.keys(targets!);
return projects.find(
Expand Down