Skip to content

Update ref.ts #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update ref.ts #2146

wants to merge 1 commit into from

Conversation

rip222
Copy link

@rip222 rip222 commented Aug 13, 2019

Deleted the redundant "updateMetatdata" function from the interface. It served the same purpose as the "updateMetadata" function. I believe it was just added by mistake.

Checklist

Description

Code sample

Proposing to delete the updateMetatdata function from docs and api

Deleted the redundant "updateMetatdata" function from the interface. It served the same purpose as the "updateMetadata" function. I believe it was just added by mistake.
@jamesdaniels jamesdaniels added this to the 6.0.0 milestone Aug 20, 2019
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge until 6.0, breaking change.

FYI @rip222 no action needed on your part, I will dismiss the review when we decided to next break.

@jamesdaniels
Copy link
Member

Addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants