Skip to content

refactor(core): remove compileComponents invocations #61032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(core): remove compileComponents invocations #61032

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Those weren't necessary.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Apr 28, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 28, 2025
@JeanMeche JeanMeche closed this May 1, 2025
@JeanMeche JeanMeche reopened this May 5, 2025
@JeanMeche JeanMeche force-pushed the compileComponents branch from f34c151 to e4d759e Compare May 5, 2025 21:40
@JeanMeche JeanMeche marked this pull request as ready for review May 8, 2025 19:36
@pullapprove pullapprove bot requested a review from thePunderWoman May 8, 2025 19:36
@JeanMeche JeanMeche force-pushed the compileComponents branch from e4d759e to e58ac32 Compare May 8, 2025 20:21
@JeanMeche JeanMeche force-pushed the compileComponents branch from e58ac32 to bcbb8f8 Compare May 8, 2025 21:30
thePunderWoman
thePunderWoman approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 9, 2025
@alxhub
Copy link
Member

alxhub commented May 9, 2025

This PR was merged into the repository by commit 3eeea56.

The changes were merged into the following branches: main, 20.0.x

alxhub pushed a commit that referenced this pull request May 9, 2025
@JeanMeche @alxhub
refactor(core): remove compileComponents invocations (#61032)
e3deb90 
Those weren't necessary.

PR Close #61032
@alxhub alxhub closed this in 3eeea56 May 9, 2025
@JeanMeche JeanMeche deleted the compileComponents branch June 2, 2025 20:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@JeanMeche @alxhub @thePunderWoman