Skip to content

fix(@angular/ssr): ensure correct referer header handling in web request conversion #30583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/angular/ssr/node/src/request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,14 @@ export function createWebRequestFromNodeRequest(
): Request {
const { headers, method = 'GET' } = nodeRequest;
const withBody = method !== 'GET' && method !== 'HEAD';
const referrer = headers.referer && URL.canParse(headers.referer) ? headers.referer : undefined;

return new Request(createRequestUrl(nodeRequest), {
method,
headers: createRequestHeaders(headers),
body: withBody ? nodeRequest : undefined,
duplex: withBody ? 'half' : undefined,
referrer,
});
}

Expand Down
46 changes: 44 additions & 2 deletions packages/angular/ssr/node/test/request_http1_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe('createWebRequestFromNodeRequest (HTTP/1.1)', () => {
server.close(done);
});

describe('GET Handling', () => {
describe('GET handling', () => {
it('should correctly handle a basic GET request', async () => {
const nodeRequest = await extractNodeRequest(() => {
request({
Expand Down Expand Up @@ -96,9 +96,51 @@ describe('createWebRequestFromNodeRequest (HTTP/1.1)', () => {
expect(webRequest.headers.get('x-custom-header1')).toBe('value1');
expect(webRequest.headers.get('x-custom-header2')).toBe('value2');
});

it('should correctly handle the referer header', async () => {
const referer = 'http://test-referer-site.com/page';
const nodeRequest = await extractNodeRequest(() => {
request({
hostname: 'localhost',
port,
path: '/with-referer',
method: 'GET',
headers: {
referer,
},
}).end();
});

expect(nodeRequest.headers['referer']).toBe(referer);

const webRequest = createWebRequestFromNodeRequest(nodeRequest);
expect(webRequest.headers.get('referer')).toBe(referer);
expect(webRequest.referrer).toBe(referer);
});

it('should handle an invalid referer header gracefully', async () => {
const invalidReferer = '/invalid-referer';
const nodeRequest = await extractNodeRequest(() => {
request({
hostname: 'localhost',
port,
path: '/with-invalid-referer',
method: 'GET',
headers: {
referer: invalidReferer,
},
}).end();
});

expect(nodeRequest.headers['referer']).toBe(invalidReferer);

const webRequest = createWebRequestFromNodeRequest(nodeRequest);
expect(webRequest.headers.get('referer')).toBe(invalidReferer);
expect(webRequest.referrer).toBe('about:client');
});
});

describe('POST Handling', () => {
describe('POST handling', () => {
it('should handle POST request with JSON body and correct response', async () => {
const postData = JSON.stringify({ message: 'Hello from POST' });
const nodeRequest = await extractNodeRequest(() => {
Expand Down
43 changes: 41 additions & 2 deletions packages/angular/ssr/node/test/request_http2_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('createWebRequestFromNodeRequest (HTTP/2)', () => {
server.close(done);
});

describe('GET Handling', () => {
describe('GET handling', () => {
it('should correctly handle a basic GET request', async () => {
const nodeRequest = await extractNodeRequest(() => {
client
Expand Down Expand Up @@ -106,9 +106,48 @@ describe('createWebRequestFromNodeRequest (HTTP/2)', () => {
expect(webRequest.headers.get('x-custom-header1')).toBe('value1');
expect(webRequest.headers.get('x-custom-header2')).toBe('value2');
});

it('should correctly handle the referer header', async () => {
const referer = 'http://test-referer-site.com/page';
const nodeRequest = await extractNodeRequest(() => {
client
.request({
':path': '/with-referer',
':method': 'GET',
referer,
})
.end();
});

expect(nodeRequest.headers['referer']).toBe(referer);

const webRequest = createWebRequestFromNodeRequest(nodeRequest);
expect(webRequest.headers.get('referer')).toBe(referer);
expect(webRequest.referrer).toBe(referer);
expect(webRequest.url).toBe(`http://localhost:${port}/with-referer`);
});

it('should handle an invalid referer header gracefully', async () => {
const invalidReferer = '/invalid-referer';
const nodeRequest = await extractNodeRequest(() => {
client
.request({
':path': '/with-referer',
':method': 'GET',
referer: invalidReferer,
})
.end();
});

expect(nodeRequest.headers['referer']).toBe(invalidReferer);

const webRequest = createWebRequestFromNodeRequest(nodeRequest);
expect(webRequest.headers.get('referer')).toBe(invalidReferer);
expect(webRequest.referrer).toBe('about:client');
});
});

describe('POST Handling', () => {
describe('POST handling', () => {
it('should handle POST request with JSON body and correct response', async () => {
const postData = JSON.stringify({ message: 'Hello from POST' });
const nodeRequest = await extractNodeRequest(() => {
Expand Down
Loading