Skip to content

docs(@angular/cli): change default test watch flag #13051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

AnObstacle
Copy link
Contributor

No description provided.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution however this flag is not for karma but for browser builder.

I think you meant to change

Also, kindly fix the commit message as per our Commit Message Guidelines:
https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#-commit-message-guidelines

@AnObstacle AnObstacle changed the title doc: update new default watch flag for ng test docs(@angular/cli): change default test watch flag Nov 26, 2018
@AnObstacle
Copy link
Contributor Author

hi @alan-agius4, sorry for the mistake, I hope it is better like that.

@alan-agius4
Copy link
Collaborator

Hi, you need to squash your commits into a single one, as like this the original commit is still present.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 27, 2018
@vikerman vikerman merged commit 81670ae into angular:master Nov 30, 2018
@AnObstacle AnObstacle deleted the patch-1 branch January 15, 2019 07:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants