Skip to content

docs: fix config name in update Fixes #13028 #13039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2018
Merged

docs: fix config name in update Fixes #13028 #13039

merged 1 commit into from
Nov 30, 2018

Conversation

krishnaanaril
Copy link
Contributor

Fixes the issue #13028

@krishnaanaril
Copy link
Contributor Author

Any hint on why some checks are failing?

alan-agius4
alan-agius4 requested changes Nov 23, 2018
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this though the CI is failing due to the incorrect commit message.

Kindly update it to

docs: fix config name in update 

Fixes #13028

@krishnaanaril krishnaanaril changed the title Fixed incorrect documentation #13028 docs: fix config name in update Fixes #13028 Nov 23, 2018
@krishnaanaril
Copy link
Contributor Author

@alan-agius4 Thanks, I've updated the PR.

alan-agius4
alan-agius4 approved these changes Nov 23, 2018
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 23, 2018
@vikerman vikerman merged commit 5979f6e into angular:master Nov 30, 2018
vikerman pushed a commit that referenced this pull request Nov 30, 2018
@krishnaanaril @vikerman
docs: fix config name in update (#13039)
5317054 
Fixes #13028
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krishnaanaril @alan-agius4 @vikerman @googlebot