Skip to content

Conversation

alan-agius4
Copy link
Collaborator

feat(@schematics/angular): use angular version 7.1.0

feat(@schematics/angular): use tsickle >=0.34.0 when creating a library

build: update @angular/packages to 7.1.0

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Nov 22, 2018
@alan-agius4 alan-agius4 changed the title Deps angular tsickle Update angular and tsickle dependencies Nov 22, 2018
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate target: major This PR is targeted for the next major release and removed target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate labels Nov 26, 2018
@vikerman vikerman merged commit 508d4df into angular:master Nov 27, 2018
@alan-agius4 alan-agius4 deleted the deps_angular_tsickle branch December 1, 2018 06:36
@maxisam
Copy link
Contributor

maxisam commented Mar 11, 2019

I got an error like

"Uncaught TypeError: You provided 'undefined' where a stream was expected. You can provide an Observable, Promise, Array, or Iterable."

after changing tsickle from >=0.25.5 to >=0.34.3

It is really strange.

"@angular/core": "^7.2.8"
"@angular/cli": "^7.3.5"
"typescript": "~3.2.4"
"rxjs": "^6.3.3"

As soon as I roll back tsickle, everything works as usual. I haven't figured out what happened exactly.

update

if I set it to 0.34.0, it works. But when I tried 0.34.2, it throws errors again.

I forgot to mention it only happens under production build.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants