Fix startup exception messages #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Before (Left), After (Right) |
Contributor
Author
|
Apologies, meant to submit this with my other changes Thursday but didn't get around to it until just now. |
sendhil
commented
Feb 24, 2025
| Raises: | ||
| None | ||
| """ | ||
| session: Optional[aiohttp.ClientSession] = None |
Contributor
Author
There was a problem hiding this comment.
The auto formatter obscures some of the changes here, but the changes are effectively these 2 lines, and the changes to line 76-77.
sendhil
commented
Feb 24, 2025
| except Exception as error: | ||
| self.logger.error( | ||
| f"lattice api publish entity error {error}\n\trequest={session.request}\n\tresponse={response.status}\n\t{entity}") | ||
| f"lattice api publish entity error {error}\n\trequest={session.request if session else None}\n\tresponse={response.status if response else None}\n\t{entity}" |
Contributor
Author
There was a problem hiding this comment.
The auto formatter obscures some of the changes here, but the changes are effectively these 2 lines, and the changes to line 62-63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you attempt to publish a message and there's a connection error the attempt at logging the error message throws an exception because
sessionand orresponsecould beNone. This change accounts for this by declaring the variables.Test Plan
You'll need to make sure your config file doesn't set
lattice-iporlattice-bearer-token