Upgradle to 9.0.0 #1930
Merged
Upgradle to 9.0.0 #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also bumps the version of oss-licenses-plugin to pick up a fix for google/play-services-plugins#309 Test: ./gradlew build
Gradle 9.0.0 has the new enforcement that Test task runs that have sources but no tests run should fail. Without this change we get Execution failed for task ':core:analytics:testDemoDebugUnitTest'. > There are test sources present and no filters are applied, but the test task did not discover any tests to execute. This is likely due to a misconfiguration. Please check your test configuration. If this is not a misconfiguration, this error can be disabled by setting the 'failOnNoDiscoveredTests' property to false. We get this because before this change AndroidCompose was always setting isIncludeAndroidResources = true which generates a source to the test task and in the case of :core:analytics it is the only source. Instead of setting isIncludeAndroidResources in AndroidCompose move to setting it in relevant build.gradle.kts files (most already had it)
dturner
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also bumps the version of oss-licenses-plugin to pick up a fix for google/play-services-plugins#309
Gradle 9.0.0 has the new enforcement that Test task runs that
have sources but no tests run should fail. Without this change we get
We get this because before this change AndroidCompose was always setting
isIncludeAndroidResources = truewhich generates a source to the testtask and in the case of
:core:analyticsit is the only source.Instead of setting
isIncludeAndroidResourcesin AndroidCompose move tosetting it in relevant
build.gradle.ktsfiles (most already had it)