Skip to content

Change ViewModel visibility from public to internal for all feature modules #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

audgns10
Copy link

@audgns10 audgns10 commented Aug 2, 2025

What I have done and why

  • Changed the visibility modifier of all ViewModel classes within their respective feature modules from public to internal, ensuring that ViewModels are only accessible within their own modules.

  • This modification improves encapsulation and enforces clear module boundaries, preventing unintended usage of ViewModels across modules.

  • By restricting access with the internal modifier, the codebase becomes more maintainable and less prone to unintended dependencies.

  • Updated each feature module separately to reflect this visibility change, keeping each commit modular and easier to review.


Updated Modules

The following feature modules have been updated:

  • BookmarksViewModel (in feature-bookmarks)
  • ForYouViewModel (in feature-foryou)
  • SearchViewModel (in feature-search)

@audgns10 audgns10 requested a review from dturner as a code owner August 2, 2025 19:05
Copy link
Author

@audgns10 audgns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dturner

Would appreciate it if you could take a look at this PR when you get the chance
Made some visibility changes to ViewModels for better encapsulation between modules.
Happy to make any changes if needed!

Copy link
Contributor

@hoc081098 hoc081098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants