Migrate codebase to Navigation 3

[dturner]

[WIP] This PR migrates the codebase to using Jetpack Navigation 3.

More details to follow...

[dturner]

I think this is redundant can be deleted. IIRC when I ran the dependency graph generation script I excluded the benchmarks module.

[dturner]

Here's the command I use:

./generateModuleGraphs.sh --exclude-module :benchmarks --exclude-module :lint --exclude-module :ui-test-hilt-manifest

[SimonMarquis]

@dturner these graphs are becoming harder to read with this new api/impl split of module 🙈

Remember the discussions about dependency graphs in #1554 ?
I feel like this could be a great opportunity to showcase the api/impl splits.

[claraf3]

I did run that particular command but it still generated this. Tried rerunning again after rebasing to main and im getting these errors

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'nowinandroid'.
> Could not create task ':generateModulesGraphvizText'.
   > 'org.gradle.api.Project org.gradle.api.artifacts.ProjectDependency.getDependencyProject()'

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to generate a Build Scan (Powered by Develocity).
> Get more help at https://help.gradle.org.

BUILD FAILED in 983ms
4 actionable tasks: 4 up-to-date
Configuration cache entry stored.
Error: dot: can't open /tmp/dep_graph_core_common.gv: No such file or directory
Done in 1 ms!
0 KiB - NaN% = 0 KiB
rm: /tmp/dep_graph_core_common.gv: No such file or directory
Parallel Configuration Cache is an incubating feature.
Calculating task graph as no cached configuration is available for tasks: generateModulesGraphvizText
Type-safe project accessors is an incubating feature.

The newly generated svg graphs are not showing properly as a result. Any idea what may be causing this?

[dturner]

We can exclude this one

[dturner]

Suggested change

	"api"(project(":core:navigation"))
	"implementation"(project(":core:navigation"))

[claraf3]

all impls need it as well, so api can just expose it to them

[dturner]

What's the reason for this dependency? I thought the api modules only needed to depend on :core:navigation for now.

[claraf3]

Removed this dependency after moving TopicScreen/TopicViewModel to impl.

[dturner]

I am not sure why this needs to be in the api module - it shouldn't be used by any other module.

[claraf3]

Moved to impl. It was in api due to the old ListDetailPane implementation which has since been replaced with the ListDetailScene.

[dturner]

I am not sure why this needs to be in the api module - it shouldn't be used by any other module.

[claraf3]

Moved to impl. It was in api due to the old ListDetailPane implementation which has since been replaced with the ListDetailScene. Good catch.

[dturner]

I understand why this was moved into the api module - so that interests can depend on it, however, this raises an interesting question: should the list own its placeholder?

In this case, I would say yes, because the Interests module was originally designed to contain more than one type of list item (the 2 being "authors" which was deprecated, and the still current "topics".

Let's move TopicDetailPlaceholder into the Interests module and rename it to InterestsListPlaceholder.

This should simplify the dependency graphs, and keeps the :feature:api modules consistently simple, containing only the navigation routes.

[dturner]

Alternatively, Interests could be merged into the Topics module. I've been meaning to do this since we removed Authors, however, I don't want to add more complexity to an already complex PR. Up to you.

[claraf3]

Moved to Interests impl and renamed to InterestsDetailPlaceholder. Also moved the resources (drawable & string) referenced by InterestsDetailPlaceholder to Interests api res.

[claraf3]

Is there a lint task that auto formats all the files? ./gradlew lint just checks for errors but doesn't auto format.