Skip to content

[Jetcaster] Handle no subscribed podcasts empty state #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 26, 2024

Conversation

arriolac
Copy link
Contributor

@arriolac arriolac commented Mar 21, 2024

Changes:

  • Handles empty state when there are no subscribed podcasts (library / discover tab hidden when no podcasts are followed)
  • Reverting FollowedPodcasts to use HorizontalPager so that the list of episodes changes as the user swipes through podcasts
Screen_recording_20240321_163113.webm

@arriolac arriolac force-pushed the chris/jetcaster/empty branch from ab9dc9f to a3a2f9c Compare March 21, 2024 20:33
@arriolac arriolac marked this pull request as ready for review March 21, 2024 20:35
@arriolac arriolac requested a review from a team as a code owner March 21, 2024 20:35
@arriolac arriolac force-pushed the chris/jetcaster/empty branch from a3a2f9c to 59462de Compare March 21, 2024 20:36
@arriolac arriolac removed the request for review from JolandaVerhoef March 21, 2024 20:38
@arriolac arriolac changed the title [Jetcaster] Handle no subscribed podcasts empty state WIP [Jetcaster] Handle no subscribed podcasts empty state Mar 21, 2024
@arriolac arriolac marked this pull request as draft March 21, 2024 20:43
@arriolac arriolac changed the title WIP [Jetcaster] Handle no subscribed podcasts empty state [Jetcaster] Handle no subscribed podcasts empty state Mar 21, 2024
@arriolac arriolac force-pushed the chris/jetcaster/empty branch from 5b90538 to 9ead83b Compare March 21, 2024 23:30
@arriolac arriolac marked this pull request as ready for review March 21, 2024 23:30
@arriolac arriolac force-pushed the chris/jetcaster/empty branch from 495df92 to c9537eb Compare March 22, 2024 00:04
@arriolac arriolac force-pushed the chris/jetcaster/empty branch from b899958 to c0846c5 Compare March 25, 2024 21:54
@arriolac arriolac force-pushed the chris/jetcaster/empty branch from c0846c5 to 35f192c Compare March 25, 2024 21:56
Copy link
Contributor

@kul3r4 kul3r4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arriolac arriolac merged commit e36547c into jetcaster/all_form_factors Mar 26, 2024
@arriolac arriolac deleted the chris/jetcaster/empty branch March 26, 2024 16:53
arriolac added a commit that referenced this pull request Mar 26, 2024
Introduces `EpisodePlayer` interface and `MockEpisodePlayer` conforming
class to mock playing an episode. This enables play/pause and the slider
to update as you would expect in a real podcast app.


[Screen_recording_20240322_160937.webm](https://github.com/android/compose-samples/assets/463186/09a4e7bd-7d99-4381-8ec2-9b2af3bfefac)

#1292 should be reviewed and merged first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants