-
Notifications
You must be signed in to change notification settings - Fork 14
Add return type to improve type coverage #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LoganBarnett
wants to merge
3
commits into
andreypopp:master
Choose a base branch
from
LoganBarnett:add-flow-coverage-pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
c607990
add a return type to Context.validate to increase flow type coverage
LoganBarnett fd72cf6
add a partial libdef for custom-error-instance to improve type coverage
LoganBarnett f338de3
remove commented code and add docs explaining the scope of the libdef
LoganBarnett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// @flow | ||
|
||
// This is a partial libdef for custom-error-instance. It's filled out enough | ||
// such that it should work for the purposes of validated. However, the | ||
// documentation shows a potentially very complex API that might be hard to Flow | ||
// to express to a general purpose audience such as `flow-typed`. | ||
declare module 'custom-error-instance' { | ||
declare class CustomError extends Error { | ||
constructor(messageOrProps?: string | Object, properties?: Object): this; | ||
|
||
// These properties redeclared here are specifically for working with | ||
// validated. They allow the functions to be rewritten under Flow's eyes. | ||
// For more information see: https://github.com/facebook/flow/issues/1517 | ||
toString: () => string; | ||
withContext: () => Error; | ||
message: string; | ||
originalMessage: string; | ||
} | ||
|
||
declare type CustomErrorApi = ( | ||
name?: string, | ||
parent?: CustomError, | ||
properties?: Object, | ||
factory?: Function, | ||
) => Class<CustomError>; | ||
|
||
declare export default CustomErrorApi; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what you think here.
Error
maybe?