Skip to content

Add PHP 8 as a build job on Travis; bump some jobs up to PHP 7.4 #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 22, 2020
Merged

Add PHP 8 as a build job on Travis; bump some jobs up to PHP 7.4 #4894

merged 11 commits into from
Jun 22, 2020

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Jun 20, 2020 •
edited
Loading

Summary

  • Upgrades CI to Ubuntu Xenial 16.04 (some required PHP extensions we're not available on trusty)
  • Bumps the stages lint, analyze, and some test jobs from PHP 7.3 to 7.4
  • Adds a test job to run against PHP 8.0.0-dev (which is allowed to fail)
  • Reports the PHP 7.4 test job if it fails

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Jun 20, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2020 •
edited
Loading

Plugin builds for e1f7ef2 are ready 🛎️!

@pierlon pierlon marked this pull request as draft June 20, 2020 02:28
@pierlon pierlon force-pushed the travis-include-php-8 branch from 47a0a28 to 0d12373 Compare June 21, 2020 16:53
@pierlon
Copy link
Contributor Author

pierlon commented Jun 21, 2020

The errors and failures from the PHP 8 job are related to image processing operations in WP and can't be fixed by the plugin (for example, gdimage resources are now GdImage objects, cf. php/php-src#4714)

@pierlon pierlon marked this pull request as ready for review June 21, 2020 17:10
@pierlon pierlon added the Infrastructure Changes impacting testing infrastructure or build tooling label Jun 21, 2020
westonruter
westonruter approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I defer to @schlessera

@westonruter westonruter added this to the v1.6 milestone Jun 22, 2020
schlessera
schlessera requested changes Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the PHP version check that can be done faster, LGTM!

@westonruter westonruter merged commit 1366834 into develop Jun 22, 2020
@westonruter westonruter deleted the travis-include-php-8 branch June 22, 2020 18:49
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 18, 2020
@westonruter westonruter added the WS:Core Work stream for Plugin core label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera requested changes

@westonruter westonruter westonruter approved these changes

Assignees

@schlessera schlessera

Labels
Changelogged Whether the issue/PR has been added to release notes. cla: yes Signed the Google CLA Infrastructure Changes impacting testing infrastructure or build tooling WS:Core Work stream for Plugin core
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pierlon @schlessera @westonruter @googlebot