Skip to content

Conversation

danog
Copy link
Contributor

@danog danog commented Oct 16, 2024

Reliance on the key is useful in some conditions, and the non-monotonicity of the key caused a very nasty bug in our code.

@bwoebi
Copy link
Member

bwoebi commented Oct 16, 2024

You don't actually need $k, the main thing you need is replacing yield from by foreach. (which will then just use the auto-incrementing default).

@danog
Copy link
Contributor Author

danog commented Oct 16, 2024

True, but it's more explicit this way.

Copy link
Member

@kelunik kelunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cover this with a test.

@danog
Copy link
Contributor Author

danog commented Mar 16, 2025

@trowski / @kelunik done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants