fix: rename S3PathSyle to S3PathStyle (typo fix)#830
Merged
aminueza merged 1 commit intoaminueza:mainfrom Mar 5, 2026
Merged
Conversation
Renames the internal type from S3PathSyle to S3PathStyle. Also updates S3PathSyleOn -> S3PathStyleOn, S3PathSyleOff -> S3PathStyleOff, S3PathSyleAuto -> S3PathStyleAuto. Closes aminueza#829
aminueza
approved these changes
Mar 5, 2026
Owner
aminueza
left a comment
aminueza
left a comment
There was a problem hiding this comment.
LGTM 👍🏼
Clean rename of the S3PathSyle typo. All occurrences updated including tests. Internal type only, no user-facing or state changes. This was tracked in our backlog as a known issue. Thanks for picking it up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames the internal type from S3PathSyle to S3PathStyle to fix the typo.
This is an internal type not exposed to users, so it's a safe rename with no schema, state, or user-facing changes.
Related Issues
Closes #829