feat(ci): add golangci-lint and govulncheck to CI workflow#743
Merged
feat(ci): add golangci-lint and govulncheck to CI workflow#743
Conversation
…ation - Upgrade actions/checkout, actions/setup-go, and golangci-lint versions for improved performance and compatibility. - Update golangci-lint configuration to version 2, consolidating linters and excluding unnecessary ones. - Adjust exclusion rules for specific files and linters to enhance linting accuracy.
…icy expiration check - Updated provider initialization in TestProvider_impl to remove unnecessary type assertion. - Modified expiration date check in minioReadILMPolicy to use IsZero() method directly for clarity. - Corrected queue configuration comparison in S3 bucket notification tests for consistency.
…and organization - Set default linters to none and explicitly enable required linters. - Consolidate linters settings for errcheck and govet, maintaining specific exclusions. - Refactor exclusion rules for better readability and organization.
…readability - Added new linters: bodyclose, noctx, and unconvert for better code quality. - Refactored exclusion rules for errcheck to improve clarity and organization. - Simplified code in data_source_minio_iam_policy_document.go and data_source_minio_server_info.go for better readability. - Updated resource_minio_iam_group.go to directly set group_name without unnecessary type conversion. - Improved test for bucket accessibility in resource_minio_s3_bucket_test.go by using http.NewRequest for better context handling.
felladrin
changed the title
- Replaced the govulncheck GitHub Action with a direct installation and execution command for improved flexibility. - Ensured the latest version of govulncheck is used for vulnerability scanning.
felladrin
approved these changes
Jan 28, 2026
- Eliminated the direct installation and execution of govulncheck from the CI workflow to streamline the process. - This change simplifies the workflow configuration while maintaining focus on other testing tasks.
felladrin
approved these changes
Jan 28, 2026
Collaborator
felladrin
left a comment
felladrin
left a comment
There was a problem hiding this comment.
I've checked the non-workflow files changed, and the changes are all optimizations. No risks. 🟢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize GitHub Actions workflows with 2026 best practices
This PR implements the following changes:
golangci-lintgovulncheckfor Go dependency vulnerability scanningpermissions,concurrency, andtimeout-minutessetup-go@v5,goreleaser-action@v6Files Changed
.github/workflows/go.yml.github/workflows/release.yml.github/workflows/create-release-tag.yml.golangci.yml.goreleaser.yml.github/release.ymlReference
Closing issues