light-16: update attachment text color#12
Open
jjmcdn wants to merge 1 commit intoaltercation:masterfrom
Open
Conversation
The definition of 'black' ended up making the attachment text nearly illegible on a stock xterm which includes 256-color support but using the solarized light-16 configuration for mutt. Changing 'black' to 'cyan' makes it much clearer without overwhelming the actual text. Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
Author
|
So I merged this into my fork, then realized this is actually done incorrectly. You need to adjust the template file since that is how the muttrc colour files are generated. Your colour scheme seems to involve switching black to that really light brown, as the default colour template for the light templates uses J_base2 (black for light, white for dark) on top of J_bg (background colour). In my own testing, it does seem to work fine. A lot of the issues I think some folks are having are really getting the colours all setup correctly in their own terminals:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definition of 'black' ended up making the attachment text nearly
illegible on a stock xterm which includes 256-color support but using the
solarized light-16 configuration for mutt. Changing 'black' to 'cyan'
makes it much clearer without overwhelming the actual text.
Signed-off-by: Joe MacDonald joe_macdonald@mentor.com