Increase vLLM health timeout to 10 minutes#1452
Conversation
Summary of ChangesHello @hamishivi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the stability of vLLM engine operations by extending the health check timeout, which is crucial for successful initialization of large language models. Concurrently, it introduces a robust evaluation framework for assessing the performance of tool-use models across multiple benchmarks, significantly improving the project's analytical capabilities for model outputs. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request increases the vLLM health check timeout from 5 to 10 minutes, which is a reasonable change to allow more time for engine initialization. It also introduces a new evaluation script scripts/eval_results.py for AIME, SimpleQA, and GPQA datasets. The script is well-structured and functional. My review includes suggestions to improve code quality by replacing a magic number with a constant in open_instruct/grpo_fast.py and refactoring the new evaluation script to reduce code duplication.
580f7b7 to
4e54c25
Compare
4e54c25 to
4948516
Compare
Increase the aiohttp timeout for the vLLM health check endpoint from 30s to 300s (10 min) to allow more time for the server to respond. Co-authored-by: Cursor <cursoragent@cursor.com>
4948516 to
99ba478
Compare
Increase timeout for vllm healthchecks. I found this was too short for training cases with long generations.