-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Labels
good first issueGood for newcomersGood for newcomers
Description
feature request
feature request
code ref:
com.alibaba.csp.sentinel.property.DynamicSentinelProperty#updateValue
RecordLog.info("[DynamicSentinelProperty] Config will be updated to: " + newValue, new Object[0]);
the newValue will invoke toString() method,each time. This might be cause performance degradation.
feature request
In my humble opinion, could add a statement before it, like
if (logger.enableInfo())
sometimes, people could disable info level log, and toString() method will not be invoked. That is, I hope this method more higher efficiency
Describe what you expected to happen
Tell us your environment
version:1.8.0
system:mbp
Anything else we need to know?
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers