Skip to content

feature request  #1735

@tain198127

Description

@tain198127

feature request

feature request

code ref:
com.alibaba.csp.sentinel.property.DynamicSentinelProperty#updateValue

 RecordLog.info("[DynamicSentinelProperty] Config will be updated to: " + newValue, new Object[0]);

the newValue will invoke toString() method,each time. This might be cause performance degradation.

feature request

In my humble opinion, could add a statement before it, like

if (logger.enableInfo())

sometimes, people could disable info level log, and toString() method will not be invoked. That is, I hope this method more higher efficiency

Describe what you expected to happen

Tell us your environment

version:1.8.0
system:mbp

Anything else we need to know?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions