[Backport][main to 0.9] | Fix nullptr crash in eviction when cache directory is externally deleted (#1498) - #1504
Merged
lihuiba merged 1 commit intoJun 26, 2026
Conversation
…ted (#1498) * Fix nullptr crash in eviction when cache directory is externally deleted When the cache directory is deleted while the cache pool is running, open() returns nullptr during eviction. The code dereferences it without a null check, causing a SIGSEGV. Add null checks in both evict(filename) and the timer-driven eviction loop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix same nullptr crash in QuotaFilePool eviction paths Apply the same null check for open() return value in QuotaFilePool::evict() and QuotaFilePool::dirEviction(), which have the identical bug as FileCachePool. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
photonlibos
added
the
bugfix
lihuiba
approved these changes
Jun 25, 2026
photonlibos
deleted the
backport-pr-3b388a17cfe0aa774725915e2307f55a73edcec6-0.9
branch
June 26, 2026 02:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the cache directory is deleted while the cache pool is running,
open() returns nullptr during eviction. The code dereferences it without
a null check, causing a SIGSEGV. Add null checks in both evict(filename)
and the timer-driven eviction loop.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Apply the same null check for open() return value in
QuotaFilePool::evict() and QuotaFilePool::dirEviction(),
which have the identical bug as FileCachePool.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Co-authored-by: Claude Opus 4.6 noreply@anthropic.com
Generated by Backport Auto PR, by cherry-pick related commits.
Please review and decide whether to merge or close this backport PR.