refactor socket pool - #1484
Merged
Merged
Conversation
lihuiba
force-pushed
the
new-socket-pool
branch
7 times, most recently
from
June 22, 2026 15:01
2d544d3 to
162c50a
Compare
1. define a new interface ```ISocketPool``` that supports connection grouping by user-defined keys, in addition to Endpoints 2. allow for user-defined callback for connection heartbeat, as construction argument 3. support TCP-Keepalive 4. re-design the implementation to support these new features 5. optimization of the data structure to eliminate redundant stores of keys (Endpoints), as well as fds 6. merge the timer and the collector thread The keys (Endpoints) were stored 3 times in: unordered_map (fdmap), StreamListNode, and PooledTCPSocketStream. Now they are stored once in StreamListHead, located at the end of StreamListHead to support variable length. And the unordered_map is changed to unordered_set. The maintainance routines, e.g. evict(), release(), collect(), etc., are changed accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.