[Backport][0.8 to 0.7] | Fix fd leak in accept() when setsockopt fails (#1248) (#1330) (#1376) - #1405
Merged
lihuiba merged 1 commit intoJun 17, 2026
Conversation
When KernelSocketServer::accept() successfully accepts a connection but setsockopt() subsequently fails, the accepted fd was leaked. Added ::close(cfd) on the error path. Co-authored-by: Jiangtian Feng <jiangtianf97@163.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
lihuiba
approved these changes
Jun 16, 2026
lihuiba
approved these changes
Jun 17, 2026
photonlibos
deleted the
backport-pr-876611bc652437518bc9f09c2b54b8eabebd4c54-0.7
branch
June 17, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When KernelSocketServer::accept() successfully accepts a connection
but setsockopt() subsequently fails, the accepted fd was leaked.
Added ::close(cfd) on the error path.
Co-authored-by: Jiangtian Feng jiangtianf97@163.com
Co-authored-by: Claude Opus 4.6 noreply@anthropic.com
Generated by Backport Auto PR, by cherry-pick related commits.
Please review and decide whether to merge or close this backport PR.