Skip to content

fix(clients): allow chunked requests on WithTransformation methods #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 17, 2025

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3897 https://algolia.atlassian.net/browse/DI-3896 https://algolia.atlassian.net/browse/DI-3893 https://algolia.atlassian.net/browse/DI-3895

Changes included:

this pr implements the chunkedPush method in every clients that has WithTransformation helpers, which allows the implementation of a subsequent helper: ReplaceAllObjectsWithTransformation

this updates the response type of the previously added helpers but they are unlikely to be used atm considering it just has been released and not even documented

@shortcuts shortcuts self-assigned this Jun 17, 2025
@shortcuts shortcuts force-pushed the feat/javascript-replaceAllObjectsWithTransformation branch from 0ee2dc0 to 4be66cf Compare June 17, 2025 11:35
@shortcuts shortcuts force-pushed the feat/with-transformation-response-shape branch from f04c413 to 9254f25 Compare June 17, 2025 11:36
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 17, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by e5eb67c08bfccf1e89421db287deb4d9ce35f847
🍃 Generated commit 340696c863978fcbd18df1bba6b5076fab446e80
🌲 Generated branch generated/feat/with-transformation-response-shape
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1718
javascript 1661
php 1550
csharp 1293
python 1063
java 1049
ruby 807
swift 409
scala 23

@shortcuts shortcuts force-pushed the feat/with-transformation-response-shape branch from aff8b9c to a160398 Compare June 17, 2025 15:06
Base automatically changed from feat/javascript-replaceAllObjectsWithTransformation to main June 18, 2025 14:07
@shortcuts shortcuts force-pushed the feat/with-transformation-response-shape branch from 4fcc10f to 916186a Compare June 18, 2025 14:30
@shortcuts shortcuts marked this pull request as ready for review June 18, 2025 14:38
@shortcuts shortcuts requested a review from a team as a code owner June 18, 2025 14:38
@shortcuts shortcuts requested review from morganleroi and millotp June 18, 2025 14:38
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, nothing to add !

@shortcuts shortcuts enabled auto-merge (squash) June 18, 2025 16:27
@shortcuts shortcuts merged commit 9dec2bb into main Jun 18, 2025
28 checks passed
@shortcuts shortcuts deleted the feat/with-transformation-response-shape branch June 18, 2025 16:45
algolia-bot added a commit that referenced this pull request Jun 18, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jun 18, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jun 18, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 18, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jun 18, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jun 18, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants