-
Notifications
You must be signed in to change notification settings - Fork 22
fix(clients): allow chunked requests on WithTransformation methods #5011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ee2dc0
to
4be66cf
Compare
f04c413
to
9254f25
Compare
💥 Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. ✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
aff8b9c
to
a160398
Compare
4fcc10f
to
916186a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, nothing to add !
…5011) (generated) [skip ci] Co-authored-by: Clément Vannicatte <[email protected]>
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3897 https://algolia.atlassian.net/browse/DI-3896 https://algolia.atlassian.net/browse/DI-3893 https://algolia.atlassian.net/browse/DI-3895
Changes included:
this pr implements the chunkedPush method in every clients that has WithTransformation helpers, which allows the implementation of a subsequent helper: ReplaceAllObjectsWithTransformation
this updates the response type of the previously added helpers but they are unlikely to be used atm considering it just has been released and not even documented