Skip to content

Conversation

@Fluf22
Copy link
Collaborator

@Fluf22 Fluf22 commented Feb 21, 2025

🧭 What and Why

🎟 JIRA Ticket: CR-7925

Changes included:

  • implement generateSecuredApiKey
  • implement getRemainingValidity

🧪 Test

Enable helper tests in templates

@Fluf22 Fluf22 requested a review from a team as a code owner February 21, 2025 16:38
@Fluf22 Fluf22 requested review from millotp and shortcuts February 21, 2025 16:38
@Fluf22 Fluf22 self-assigned this Feb 21, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 21, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 03285b6156cfc18abb8cd6f5f0e638ee83e67463
🍃 Generated commit 18fb3211e48c434b95d026ca21d34ac996356c60
🌲 Generated branch generated/fix/scala-secured-key
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1636
go 1623
php 1479
csharp 1367
java 1105
python 1095
ruby 786
swift 745
scala 23

@Fluf22 Fluf22 force-pushed the fix/scala-secured-key branch from 11944da to e96e297 Compare February 24, 2025 15:19
@Fluf22 Fluf22 force-pushed the fix/scala-secured-key branch from 9271065 to ea4bfdc Compare February 25, 2025 08:06
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok respect scala man

@Fluf22 Fluf22 force-pushed the fix/scala-secured-key branch from f9cc696 to 736163d Compare February 27, 2025 17:11
@Fluf22 Fluf22 requested review from millotp and shortcuts February 28, 2025 09:02
Copy link
Contributor

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge !

@Fluf22 Fluf22 requested a review from millotp February 28, 2025 10:44
Copy link
Contributor

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg !

@Fluf22 Fluf22 merged commit 043fb81 into main Feb 28, 2025
28 checks passed
@Fluf22 Fluf22 deleted the fix/scala-secured-key branch February 28, 2025 10:58
algolia-bot added a commit that referenced this pull request Feb 28, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Feb 28, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants