Handle buggy onclick event on iOS #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanPetr
force-pushed
the
fix/mobile_hover
branch
from
5b57b21 to
979bbc8
Compare
|
Thank you! Put it into a dev site, and my initial testing looks good. Works as I'd expect on my older ipad. Throwing it at the rest of my office, as they've got a variety of apple devices, and we'll see how it goes. |
|
Thanks for coming back to me @sam327 💯 |
|
So, this looks good to us. Tested on a half-dozen apple devices, and a couple non-apple ones (for good measure). |
|
Thanks for your help @sam327! 💯 It's been merged and will be part of the next release. |
|
This is amazing! Let's see how to incorporate this in autocomplete.js itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
@sam327, could you give it a try if it fixes your issue?