Skip to content

Don't render unnecessary templates and JS #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Don't render unnecessary templates and JS #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/code/community/Algolia/Algoliasearch/Model/Observer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ public function useAlgoliaSearchPopup(Varien_Event_Observer $observer)
if ($this->config->isPopupEnabled() || $this->config->isInstantEnabled()) {
$observer->getLayout()->getUpdate()->addHandle('algolia_search_handle');

if ($this->config->isPopupEnabled()) {
$observer->getLayout()->getUpdate()->addHandle('algolia_search_handle_autocomplete');
}

if ($this->config->isInstantEnabled() || $this->config->replaceCategories()) {
$observer->getLayout()->getUpdate()->addHandle('algolia_search_handle_instantsearch');
}

if ($this->config->isDefaultSelector()) {
$observer->getLayout()->getUpdate()->addHandle('algolia_search_handle_with_topsearch');
} else {
Expand Down
54 changes: 34 additions & 20 deletions app/design/frontend/base/default/layout/algoliasearch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
<action method="addJs"><script>algoliasearch/internals/frontend/algoliaBundle.min.js</script></action>
<action method="addJs"><script>algoliasearch/internals/frontend/common.js</script></action>

<action method="addJs"><script>algoliasearch/instantsearch.js</script></action>
<action method="addJs"><script>algoliasearch/autocomplete.js</script></action>

<block type="core/text" name="algolia-polyfill">
<action method="setText">
<text>
Expand All @@ -27,6 +24,28 @@
</block>
</reference>

<reference name="content">
<block type="core/template" before="content" template="algoliasearch/internals/beforecontent.phtml" name="algolia-beforecontent"/>
</reference>
</algolia_search_handle>

<algolia_search_handle_with_topsearch>
<reference name="top.search">
<action method="setTemplate"><template>algoliasearch/autocomplete.phtml</template></action>
</reference>
</algolia_search_handle_with_topsearch>

<algolia_search_handle_no_topsearch>
<reference name="head">
<block type="core/template" template="algoliasearch/autocomplete.phtml" name="algolia-autocomplete"/>
</reference>
</algolia_search_handle_no_topsearch>

<algolia_search_handle_autocomplete>
<reference name="head">
<action method="addJs"><script>algoliasearch/autocomplete.js</script></action>
</reference>

<reference name="before_body_end">
<!-- Multi-category Autocomplete templates -->
<block type="core/template" template="algoliasearch/autocomplete/product.phtml" name="algolia-autocomplete-product"/>
Expand All @@ -36,6 +55,17 @@
<block type="core/template" template="algoliasearch/autocomplete/suggestion.phtml" name="algolia-autocomplete-suggestion"/>
<block type="core/template" template="algoliasearch/autocomplete/menu.phtml" name="algolia-autocomplete-menu"/>

<!-- INSERT YOUR CUSTOM TEMPLATES HERE -->
<!-- Example: <block type="core/template" template="algoliasearch/[autocomplete_or_instantsearch]/your_custom_template_name.phtml" name="algolia-your-custom-template-name"/> -->
</reference>
</algolia_search_handle_autocomplete>

<algolia_search_handle_instantsearch>
<reference name="head">
<action method="addJs"><script>algoliasearch/instantsearch.js</script></action>
</reference>

<reference name="before_body_end">
<!-- Instant search results page templates -->
<block type="core/template" template="algoliasearch/instantsearch/wrapper.phtml" name="algolia-instantsearch-wrapper"/>
<block type="core/template" template="algoliasearch/instantsearch/hit.phtml" name="algolia-instantsearch-hit"/>
Expand All @@ -46,23 +76,7 @@
<!-- INSERT YOUR CUSTOM TEMPLATES HERE -->
<!-- Example: <block type="core/template" template="algoliasearch/[autocomplete_or_instantsearch]/your_custom_template_name.phtml" name="algolia-your-custom-template-name"/> -->
</reference>

<reference name="content">
<block type="core/template" before="content" template="algoliasearch/internals/beforecontent.phtml" name="algolia-beforecontent"/>
</reference>
</algolia_search_handle>

<algolia_search_handle_with_topsearch>
<reference name="top.search">
<action method="setTemplate"><template>algoliasearch/autocomplete.phtml</template></action>
</reference>
</algolia_search_handle_with_topsearch>

<algolia_search_handle_no_topsearch>
<reference name="head">
<block type="core/template" template="algoliasearch/autocomplete.phtml" name="algolia-autocomplete"/>
</reference>
</algolia_search_handle_no_topsearch>
</algolia_search_handle_instantsearch>

<algolia_search_handle_prevent_backend_rendering>
<reference name="left_first">
Expand Down