Skip to content

Update copyQueryRules to use scopedCopyIndex method #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

Update copyQueryRules to use scopedCopyIndex method #1166

merged 1 commit into from
Jun 9, 2020

Conversation

bsuravech
Copy link
Contributor

Based on the updated PHP Client, I've updated the copyQueryRules() method to use the scopedCopyIndex. This is the alternative for PR#1161.

@bsuravech bsuravech requested a review from damcou June 8, 2020 14:19
@bsuravech
Copy link
Contributor Author

@maxiloc this PR will go out in the next release if it's been approved.

@bsuravech
Copy link
Contributor Author

This passed in TravisCI: https://travis-ci.org/github/algolia/algoliasearch-magento/jobs/696051163

damcou
damcou approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsuravech bsuravech merged commit ac72cc9 into develop Jun 9, 2020
@bsuravech bsuravech deleted the fix/query-rules-scope-copy branch June 9, 2020 13:37
@bsuravech bsuravech mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsuravech @damcou