Fix autocomplete bottom links #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanPetr
suggested changes
Oct 19, 2018
| if (keys.length > 1) { | ||
| ors += ', <span><a href="' + keys[1].url + '">' + keys[1].key + '</a></span>'; | ||
| if (isCategoryFacetEnabled) { | ||
| if (keys.length > 0) { |
There was a problem hiding this comment.
Can those 2 conditions be replaced by a cycle?
| @@ -336,12 +336,21 @@ document.addEventListener("DOMContentLoaded", function (e) { | |||
|
|
|||
| var ors = ''; | |||
|
|
|||
| if (keys.length > 0) { | |||
| ors += '<span><a href="' + keys[0].url + '">' + keys[0].key + '</a></span>'; | |||
| var isCategoryFacetEnabled = false; | |||
There was a problem hiding this comment.
Right now, the conditions happening no matter if there are some keys or not, which is not super effective. Can it be run only if some keys are present? Or can keys be retrieved only if categories are in facets? It's not effective to do both :)
JanPetr
suggested changes
Nov 5, 2018
| ors += ', <span><a href="' + keys[1].url + '">' + keys[1].key + '</a></span>'; | ||
| var orsTab = []; | ||
| for (var i = 0; i<algoliaConfig.facets.length; i++) { | ||
| if (algoliaConfig.facets[i].attribute == "categories") { |
There was a problem hiding this comment.
The if and for to check if categories are present are redundant to for on line 324. It's already checked that categories are present. If they wouldn't, keys would be an empty array.
So lines 341, 342, 347 (break;) can be removed.
At the same time, could you add spaces to for arguments?:
for (var i = 0; i < keys.length && i < 2 ; i++)
rbrown
added a commit
to rbrown/algoliasearch-magento
that referenced
this pull request
Jan 15, 2019
* master: (39 commits) Bump to 1.15.0 (algolia#1088) Fix error with configuration save while query rules are disabled in Algolia engine (algolia#1077) Fix special prices when customer groups are enabled (algolia#1071) Fix autocomplete bottom links (algolia#1066) update version number on mysql upgrade file update grid default direction asc on jobId Exclude non-salable subproducts from price calculation (algolia#1075) Improve name of "Remove inactive products" indexer (algolia#1054) Bump to 1.14.1 (algolia#1073) Remove color facet query rule (algolia#1072) PR updates - add view action link for indexing queue grid and add additional job methods to the list match updated logging in queue feedback fixes and add archive table long form array update indexing queue statuses notification Indexing Queue Status preliminary update to indexing queue job view add clearQueue method to Queue model and add preliminary viewAction for queue/job item view preliminary indexing queue controller, block, entity update getQueueInfo method for readable structure ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "ors" category links when the categories facet is not active