json4s 4.0.5 #653
Merged
json4s 4.0.5 #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests are failing due to improper test environment setup :-( |
|
@aallam could you please take a look |
|
Hi all, is it ready to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Upgraded json4s dependency to v4.0.5, other dependencies to their latest versions.
What problem is this fixing?
Users of Algolia search client library are blocked at the moment with json4s v3.6.x since there's binary incompatibility with v4.x code.
Keeping dependencies up to date would allow users to migrate their codebase to the latest json4s.