Skip to content

feat: custom request #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 21, 2021
Merged

feat: custom request #645

merged 5 commits into from
Oct 21, 2021

Conversation

aallam
Copy link
Member

@aallam aallam commented Oct 15, 2021 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related Issue n/a
Need Doc update yes

Describe your change

Add support for custom requests, with the following DSL:

val myCustomRequest = CustomRequest(
  verb = POST,
  path = Seq("1", "indexes", "indexName", "query"),
  body = Some("""{"query": "myQuery"}"""),
  endpoint = RequestEndpoint.Search
)

custom request myCustomRequest

@aallam aallam requested a review from DevinCodes October 15, 2021 09:34
DevinCodes
DevinCodes reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@DevinCodes DevinCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @aallam! 🙇‍♂️ Is there someone proficient in Scala that could review the code?

@aallam aallam force-pushed the feat/custom-request branch from add4b50 to 507345e Compare October 15, 2021 10:25
@DevinCodes
Copy link
Contributor

@aallam could you please check why the CI is failing? 🙂 Thank you in advance!

@aallam
Copy link
Member Author

aallam commented Oct 21, 2021

@DevinCodes here we go! 🚀

@aallam aallam merged commit 6ed1018 into master Oct 21, 2021
@aallam aallam deleted the feat/custom-request branch October 21, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevinCodes DevinCodes DevinCodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aallam @DevinCodes