Skip to content

fea(recommend): client implementation #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 28, 2021
Merged

fea(recommend): client implementation #644

merged 9 commits into from
Sep 28, 2021

Conversation

aallam
Copy link
Member

@aallam aallam commented Sep 27, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related Issue Fix #643
Need Doc update yes

Describe your change

Recommend Client API implementation.

@aallam aallam requested a review from Haroenv September 27, 2021 09:19
@aallam aallam requested a review from Haroenv September 28, 2021 08:51
Copy link

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, although I'm not sure the name in the dsl is correct (others seem to be plural)

@aallam aallam requested a review from Haroenv September 28, 2021 09:11
Copy link

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this works as expected!

@aallam aallam merged commit 4dc225e into master Sep 28, 2021
@aallam aallam deleted the feat/recommend-client branch September 28, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend client
2 participants