Add support for fields param to google_places_details lookup#1514
Closed
ericds wants to merge 1 commit intoalexreisner:masterfrom
Closed
Add support for fields param to google_places_details lookup#1514ericds wants to merge 1 commit intoalexreisner:masterfrom
ericds wants to merge 1 commit intoalexreisner:masterfrom
Conversation
Owner
|
Thanks for this, and sorry I somehow missed it. Functionality was added by #1572. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @alexreisner,
I modeled support for a fields param after the fields param in the google_places_search lookup.
This adds support for a fields param without changing existing behavior if you don't pass a fields param.
Please let me know if you're open to adding support for a fields param to this lookup and if you'd like to see any changes. If you're open to the change, I could also update the readme as a part of the PR.
Thanks!