Skip to content

Add support for connecting through Unix socket#11

Merged
alexandre-daubois merged 1 commit into
mainfrom
unix-socket
Apr 8, 2026
Merged

Add support for connecting through Unix socket#11
alexandre-daubois merged 1 commit into
mainfrom
unix-socket

Conversation

@alexandre-daubois

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds first-class support for connecting to Caddy’s admin API via a Unix domain socket (in addition to existing HTTP/HTTPS support), updating the fetcher, CLI validation/help text, and documentation accordingly.

Changes:

  • Add Unix-socket dialing support to HTTPFetcher and expose IsUnixSocket() so TLS config/reload can be skipped appropriately.
  • Extend CLI validation and tests to accept unix//... / unix:///... addresses and disallow TLS options with Unix sockets.
  • Document Unix-socket usage across README and docs (CLI reference, Caddy configuration, Docker).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
README.md Mentions Unix socket support in the feature list.
internal/fetcher/http.go Adds Unix-socket transport dialing and IsUnixSocket().
internal/fetcher/http_test.go Adds unit + integration tests for Unix-socket fetching.
internal/app/run.go Updates CLI help/flags; skips TLS config when using Unix sockets; validates unix//.
internal/app/run_test.go Adds validation tests for Unix socket addresses and TLS-option incompatibility.
internal/app/daemon.go Skips TLS reload when using a Unix-socket connection.
docs/docker.md Adds Docker/Docker Compose guidance for mounting and using the admin socket.
docs/cli-reference.md Updates --addr and EMBER_ADDR docs + examples for Unix sockets.
docs/caddy-configuration.md Documents configuring Caddy admin via Unix socket and connecting Ember to it.
cmd/ember/main_test.go Updates expected validation error text for invalid --addr.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/fetcher/http.go
Comment thread internal/app/run.go Outdated
Comment thread internal/fetcher/http_test.go
Comment thread internal/fetcher/http_test.go

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/fetcher/unix.go
Comment thread internal/app/run.go Outdated
Comment thread internal/fetcher/http_test.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexandre-daubois alexandre-daubois merged commit 99a5fae into main Apr 8, 2026
9 checks passed
@alexandre-daubois alexandre-daubois deleted the unix-socket branch April 8, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants