Improve performance of lexers.Get function - #351
Merged
alecthomas merged 2 commits intoApr 25, 2020
Merged
Conversation
Look for a lexer by file extension only when it failed to find a lexer by name
Owner
|
Seems fairly reasonable, and I can't imagine a situation where it could break existing code really. |
mrsdizzie
pushed a commit
to mrsdizzie/chroma
that referenced
this pull request
Jul 15, 2020
* Benchmark test for lexers.Get function * Improve performance of lexers.Get function Look for a lexer by file extension only when it failed to find a lexer by name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following benchmark test:
Shows the following results
Which is not so fast for a function that simply returns a lexer for a language. The reason is that we always try to find a lexer by a filename: https://github.com/alecthomas/chroma/blob/master/lexers/internal/api.go#L54. It has been done due to #94.
@alecthomas what do you think about returning a lexer if we found one by a provided name and only if we didn't find one we'd try to search by file extension? That would dramatically improve the performance:
I've included the benchmark test just for demonstrating purposes