perf(svg): defer embedded font encoding until output is written - #1355
Merged
Conversation
Registering the default SVG formatter base64-encoded the embedded 390 KB Liberation Mono font during init, costing about 0.4 ms and half a megabyte of allocations in every program importing the formatters package. Add an EmbedFontProvider option that takes the font as a function, and only call it when the formatter actually writes output. EmbedFont is unchanged and now wraps EmbedFontProvider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering the default SVG formatter base64-encodes the embedded 390 KB Liberation Mono font at init, in every program importing the formatters package. This adds an EmbedFontProvider option that takes the font as a func() string and defers the call until the formatter actually writes output. EmbedFont is unchanged and now wraps it.
GODEBUG=inittrace=1Part of a series reducing the cost of importing chroma (lexers + styles + formatters) from ~15.4 ms to ~1.1 ms.