fix(cmd/chroma): --html-styles ignores the other --html-* flags - #1348
Open
VXNCXNX wants to merge 2 commits into
Open
fix(cmd/chroma): --html-styles ignores the other --html-* flags#1348VXNCXNX wants to merge 2 commits into
VXNCXNX wants to merge 2 commits into
Conversation
Aligns cmd/chroma module with root module dependency version, fixing go build failures from version mismatch.
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1347, which is needed for
cmd/chromato build at all.--html-stylesignores every other--html-*flag.After:
Generating a stylesheet is exactly when
--html-prefixmatters most, since the prefix has to agree with whatever generated the HTML. Emitting unprefixed CSS produces a stylesheet that silently matches nothing.Cause
but
--html-styleswrites CSS from the html formatter regardless of which formatter is selected. So unless you also pass-f html, which is pointless when you only want the stylesheet, the html options are never applied.Same for
--html-lines-table,--html-highlight,--html-linkable-linesand the rest of the group.The fix
A small
usesHTMLFormatter()covering both cases, at the one call site.Unchanged, checked before and after:
-f html --html-prefix=zz-still emitszz-chroma, and a bare--html-styleswith no other flags is byte-identical.Verification
TestHTMLStylesAppliesHTMLOptionsincmd/chroma/main_test.gosetscli.Formatter = "terminal"with--html-styles,--html-prefixand--html-tab-width, then asserts both appear in the CSS.Reverting the condition to
cli.Formatter == "html"fails it:go test ./...passes in both the root module andcmd/chroma, andgolangci-lint runat the root is clean.Disclosure: written with AI assistance (Claude Code). I built both binaries, produced the before and after above by running them, and ran the revert check myself.