Update Solarized Light to use correct background color - #1250
Merged
Conversation
The Background color for Solarized Light was set to `#eee8d5`, which is the "base 2" background highlights color listed on the [Solarized website](https://ethanschoonover.com/solarized/#:~:text=The%20Values). This commit replaces it with the "base 3" background color `#fdf6e3`, which is the correct shade for backgrounds.
alecthomas
approved these changes
Apr 27, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Background color for Solarized Light is set to
#eee8d5, though this a darker shade than most implementations of Solarized. Based on the hex values on the Solarized website, this is the "base 2 - background highlights" color instead of the "base 3" one that's meant for background use (#fdf6e3); this PR swaps in that value instead.It looks like this was previously proposed as part of #469 long ago, though that also included a number of other changes; hoping this one alone is a bit less controversial 😁