Skip to content

Appveyor setup #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Appveyor setup #7

wants to merge 9 commits into from

Conversation

kkirstein
Copy link

@aldanor I somehow messed up my branches, but now you should see the appveyor setup as a single commit.

kirk-ut added 9 commits June 12, 2015 15:40
add #[inline] attributes for simple winapi wrappers as suggested by
@retep998

retep998@c121ce2
+ setup rust

! fix ps environment variable

! fix rust installer name

! fix rust installer name (now really)

+ run cargo test

! fix test_script typo

! use WebRequest for file download

! fix ps script indentation

+ generate missing folder

! use github release for hdf5 binary

+ prepare for muliple rust versions

! enable build with nightly rust

! fix environment indent

! fix rust installer name for multiple versions

+ appveyor build status badge

! alt-test for appveyor build status badge
This was referenced Jul 6, 2015
@aldanor
Copy link
Owner

aldanor commented Jul 6, 2015

@kkirstein I wonder if we can use a prebuilt binary from continuum so we don't have to link to hdf5.dll in your repo? I think they build it for mingw.

So it could be something like this (7z is already available on appveyor):

- ps: Start-FileDownload https://repo.continuum.io/pkgs/free/win-64/hdf5-1.8.15.1-2.tar.bz2
- 7z x hdf5-1.8.15.1-2.tar.bz2
- 7z x hdf5-1.8.15.1-2.tar

@aldanor
Copy link
Owner

aldanor commented Jul 6, 2015

@kkirstein Also, it would be nice (but is no biggie) if this whole PR was squashed into just one commit -- you can just do a git rebase --interactive, mark the commits to squash, and then git push --force.

@kkirstein
Copy link
Author

@aldanor currently I have to use a hdf5.dll specially compiled with gcc (instead of msvc). Originally I wanted to pull that in from dropbox, but it looks like Start-FileDownload has some problems with dropbox html-redirections. Do you know, how the binaries from continuum are compiled?

@kkirstein
Copy link
Author

@aldanor Regarding the squashed commit: This is exactly what I (tried) to do, but I somehow messed it up.

@aldanor
Copy link
Owner

aldanor commented Jul 6, 2015

@kkirstein re: rebasing, would you care to try it again? :)

Re: hdf5.dll, it looks like continuum is also using the MSVC stack to build hdf5.dll... it also looks like MinGW is not officially supported by HDF5 Group at all...

By the way, have you tried bulding / running the tests with MSVC hdf5.dll on Rust nightly? If it works, we can use the official HDF5 binaries and only run the tests on nightly till MSVC support lands in Rust 1.2 stable?

@kkirstein
Copy link
Author

@aldanor I just tried the msvc target of rust-nightly, but it seems to be still quite alpha (missing symbols from msvc-runtime). I didn't think of using "rust-nightly-gnu" with the MSVC-hdf5.dll and will give it a try...

@kkirstein
Copy link
Author

@aldanor Well actually rebasing for appveyor setup was successful, the problem is that my branch contains other changes as well (Yes I know, it is not a good idea to perform several changes within one branch..). Maybe you just want to cherry-pick the appveyor commit: c13560a
Otherwise, I just re-fork your master and generate another PR. (Sorry for the mess, just learning how to collaborate with GitHub).

@kkirstein
Copy link
Author

@aldanor BTW, rustc-nightly-xx-gnu does not work with MSVC hdf5. So, we have to stick with the MinGW-compiled hdf5 for now. Although, this is not officially supported by HDFGroup (anymore), it compiles out-of-the box, thanks to cmake.

@aldanor
Copy link
Owner

aldanor commented Jul 15, 2015

Closed via 67cc73a

@aldanor aldanor closed this Jul 15, 2015
@aldanor
Copy link
Owner

aldanor commented Jul 15, 2015

Thanks for setting this up, @kkirstein! It seems to work just fine (aside from the whole mingw business), now we just have to wait for MSVC support to land in Rust (hopefully in 1.2.0?), then we can switch to using only the official binaries from HDF Group.

@kkirstein
Copy link
Author

@aldanor In the meantime I've also setup a MSVC build on appveyor with rust-nightly, but it still fails compiling basic modules, e.g. pkg-config. So, I would suggest to wait for a more stable MSVC support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants