-
Notifications
You must be signed in to change notification settings - Fork 95
Appveyor setup #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add #[inline] attributes for simple winapi wrappers as suggested by @retep998 retep998@c121ce2
+ setup rust ! fix ps environment variable ! fix rust installer name ! fix rust installer name (now really) + run cargo test ! fix test_script typo ! use WebRequest for file download ! fix ps script indentation + generate missing folder ! use github release for hdf5 binary + prepare for muliple rust versions ! enable build with nightly rust ! fix environment indent ! fix rust installer name for multiple versions + appveyor build status badge ! alt-test for appveyor build status badge
@kkirstein I wonder if we can use a prebuilt binary from continuum so we don't have to link to So it could be something like this (7z is already available on appveyor): - ps: Start-FileDownload https://repo.continuum.io/pkgs/free/win-64/hdf5-1.8.15.1-2.tar.bz2
- 7z x hdf5-1.8.15.1-2.tar.bz2
- 7z x hdf5-1.8.15.1-2.tar |
@kkirstein Also, it would be nice (but is no biggie) if this whole PR was squashed into just one commit -- you can just do a |
@aldanor currently I have to use a hdf5.dll specially compiled with gcc (instead of msvc). Originally I wanted to pull that in from dropbox, but it looks like |
@aldanor Regarding the squashed commit: This is exactly what I (tried) to do, but I somehow messed it up. |
@kkirstein re: rebasing, would you care to try it again? :) Re: By the way, have you tried bulding / running the tests with MSVC hdf5.dll on Rust nightly? If it works, we can use the official HDF5 binaries and only run the tests on nightly till MSVC support lands in Rust 1.2 stable? |
@aldanor I just tried the msvc target of rust-nightly, but it seems to be still quite alpha (missing symbols from msvc-runtime). I didn't think of using "rust-nightly-gnu" with the MSVC-hdf5.dll and will give it a try... |
@aldanor Well actually rebasing for appveyor setup was successful, the problem is that my branch contains other changes as well (Yes I know, it is not a good idea to perform several changes within one branch..). Maybe you just want to |
@aldanor BTW, |
Closed via 67cc73a |
Thanks for setting this up, @kkirstein! It seems to work just fine (aside from the whole mingw business), now we just have to wait for MSVC support to land in Rust (hopefully in 1.2.0?), then we can switch to using only the official binaries from HDF Group. |
@aldanor In the meantime I've also setup a MSVC build on appveyor with rust-nightly, but it still fails compiling basic modules, e.g. pkg-config. So, I would suggest to wait for a more stable MSVC support. |
@aldanor I somehow messed up my branches, but now you should see the appveyor setup as a single commit.