-
Notifications
You must be signed in to change notification settings - Fork 6
PS-821 databox - integration - happyscribe integration #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
$translatedTranscriptionId = ''; | ||
|
||
do { | ||
sleep(5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to subscribe to a webhook from Happyscribe
|
||
private function translate($sourceTranscriptionId, $targetLanguage) | ||
{ | ||
// translate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless comment
|
||
// retrieve transcript export when ready | ||
do { | ||
sleep(3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to subscribe to a webhook from Happyscribe
} | ||
} | ||
|
||
private function exportTranscription($transcriptionId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing return type
|
||
do { | ||
// first wait 5 second before check transcript status | ||
sleep(5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to subscribe to a webhook from Happyscribe
|
||
public function buildConfiguration(NodeBuilder $builder): void | ||
{ | ||
$builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use camelCase style
|
||
public function buildConfiguration(NodeBuilder $builder): void | ||
{ | ||
$builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use camelCase style everywhere
->scalarNode('organization_id') | ||
->isRequired() | ||
->cannotBeEmpty() | ||
->info('Id of the organization to save the transcription in') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
->info('Id of the organization to save the transcription in') | |
->info('ID of the Happyscribe organization') |
->scalarNode('transcript_format') | ||
->defaultValue('vtt') | ||
->cannotBeEmpty() | ||
->info('Specify the export format of the transcript (srt, vtt, txt, docx, pdf, json, html)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add validation or use enumNode
|
||
public static function getName(): string | ||
{ | ||
return 'core.happyscribe'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not core
No description provided.