Skip to content

Conversation

aynsix
Copy link
Collaborator

@aynsix aynsix commented Sep 11, 2025

No description provided.

@aynsix aynsix added the WIP label Sep 11, 2025
@aynsix aynsix removed the WIP label Sep 15, 2025
@aynsix aynsix requested a review from 4rthem September 15, 2025 08:52
$translatedTranscriptionId = '';

do {
sleep(5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to subscribe to a webhook from Happyscribe


private function translate($sourceTranscriptionId, $targetLanguage)
{
// translate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless comment


// retrieve transcript export when ready
do {
sleep(3);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to subscribe to a webhook from Happyscribe

}
}

private function exportTranscription($transcriptionId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing return type


do {
// first wait 5 second before check transcript status
sleep(5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to subscribe to a webhook from Happyscribe


public function buildConfiguration(NodeBuilder $builder): void
{
$builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use camelCase style


public function buildConfiguration(NodeBuilder $builder): void
{
$builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use camelCase style everywhere

->scalarNode('organization_id')
->isRequired()
->cannotBeEmpty()
->info('Id of the organization to save the transcription in')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
->info('Id of the organization to save the transcription in')
->info('ID of the Happyscribe organization')

->scalarNode('transcript_format')
->defaultValue('vtt')
->cannotBeEmpty()
->info('Specify the export format of the transcript (srt, vtt, txt, docx, pdf, json, html)')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add validation or use enumNode


public static function getName(): string
{
return 'core.happyscribe';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants