Merge Dev #2
Merged
Merge Dev #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed By: mzlee Differential Revision: D6638538 fbshipit-source-id: 4b11b8f4f88aa533ac0467348df36e5780bfbb70
Summary: This is a leftover from recent changes in D6595780 where a prop application step was moved out to separare mount block. Differential Revision: D6640736 fbshipit-source-id: 70de0f55f992a7912e222ec4bf9ade1c9bad99f2
Summary: Buck is failing due to missing args: https://circleci.com/gh/facebook/react-native/29268 Closes #17346 Differential Revision: D6642181 Pulled By: hramos fbshipit-source-id: 399d3c5f197ae0de9748a592def945c14ac1d348
Reviewed By: shergin Differential Revision: D6639418 fbshipit-source-id: ef973cfebb94325579525bdcd3990737fe576ef8
…rfaceRootShadowView Summary: Fix calculating layout in `RCTSurfaceRootShadowView` as the `minWidth` is set doubled in `calculateLayoutWithMinimumSize:maximumSize:`. cc shergin Closes #17203 Differential Revision: D6642437 Pulled By: shergin fbshipit-source-id: 3483c952c9ecf0132182a156b7b916eb1e975424
Summary: `ScrollView` has a bunch of `onFoo` handlers for scrolling-related events, most of which have a proptype defined and are documented. However, `onScrollBeginDrag` and `onScrollEndDrag` do not currently have a proptype and are not currently documented (as noted at https://stackoverflow.com/a/41793747/1709587). It seems reasonable to bring consistency and to provide documentation of these otherwise hard-to-discover props. I haven't added or run any tests, and don't plan to do so (beyond waiting and seeing that no existing checks fail in CircleCI). I have also created a PR to update the documentation at facebook/react-native-website#99 *(None needed; this isn't a functionality change.)* Closes #17368 Differential Revision: D6642695 Pulled By: TheSavior fbshipit-source-id: fa40ed2ae6d5947a161b816a47441d8f5d4d9c4d
Summary: Related to #15126, and this would be useful for use React DevTools on real device without modify `setupDevtools.js`. In Android emulator, the host of `SourceCode.scriptURL` is same with `PlatformConstants.ServerHost` so we can just replace it. * Tested on iOS device with [react-devtools](https://github.com/facebook/react-devtools/tree/master/packages/react-devtools) package. * Tested on Android emulator, the `getDevServer` module got the correctly hostname so that don't need `adb reverse`. [ENHANCEMENT] [setupDevtools] Set host of development server for setupDevtools Closes #15547 Differential Revision: D6544980 Pulled By: javache fbshipit-source-id: a286874bcef0501c5d2e0be2251d58c236a5534a
Summary: `renderItem` on `SectionList` is within the `OptionalProps` group of props but it is not actually marked as optional. Which means that doing things such as in the example where each section has its own `renderItem` and no `renderItem` prop is passed into `SectionList` will fail flow. Create a `SectionList` where each section has it's own `renderItem` and do not pass in a `renderItem` into `SectionList`. Run flow, it should error. [GENERAL] [MINOR] [SectionList] -Makes `renderItem` prop on `SectionList` optional for flow. Closes #17262 Differential Revision: D6645672 Pulled By: hramos fbshipit-source-id: 1096e8c4998c14003cf42f29ea559505082047c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in Dev to PR before creating PR.